Repository navigation
fix: remove unnecessary body from swappability detection helper - #85
Merged
martinmoene merged 1 commit intoSep 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
is_nothrow_swappabledetection helper has a non-void return type but an empty function body, as reported in #83. It is only referenced in an unevaluateddecltypeexpression, so it needs a declaration rather than a definition. Replace the empty body with a semicolon, matching the adjacent detection helpers.Fixes #83.
Validation: the existing test executable compiles and runs successfully with GCC 14 under C++98, C++11, C++14, C++17, and C++20, with return-type warnings treated as errors. This is a static-analysis cleanup; no runtime behavior change is intended.